Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more features flags and default values to system_settings.py #395

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Add more features flags and default values to system_settings.py #395

merged 1 commit into from
Jun 15, 2020
+6 −0

Commits on Jun 3, 2020

  1. Update system_settings.py 

    I figured since [Sal's 'Settings' wiki page](https://github.com/salopensource/sal/wiki/Settings) states the following...
```
There are defaults set in sal/system_settings.py, but they can be overridden if you choose
```
... that it might be a good idea to enumerate most every toggle-able feature within the `server_settings.py` file. That said... 

This PR suggests the following changes to `sal/sal/system_settings.py`:
- Add comment explanation (pulled from the wiki page) above `EXCLUDED_FACTS` definition
- Add `IGNORE_FACTS` setting with default value of `[]`
- Add `ADD_TO_ALL_BUSINESS_UNITS` with default value of `False`
- Add `ADD_NEW_MACHINES` with default value of `True`
    @ChefAustin
    ChefAustin authored Jun 3, 2020
    Configuration menu
    Copy the full SHA
    794c5da View commit details
    Browse the repository at this point in the history