Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a link to the older version of Salsa in the document #451

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

xffxff
Copy link
Member

@xffxff xffxff commented Jun 19, 2023

related to #448

As Salsa-2022 is no yet complete and it is still unstable, there are some users who continue to use the old version of Salsa, or prefer using it due to its more stable API. Therefore, I think it is necessary to re-deploy the book for the older version of Salsa.

I have deployed the book for the older version from commit 754eea8b5f8a31b1100ba313d59e41260b494225 of Salsa on https://old-salsa-rs.netlify.app/

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for salsa-rs failed.

Name Link
🔨 Latest commit fa4dc3c
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/653dbdfdd98856000835827b

@xffxff xffxff force-pushed the old_salsa_link branch 2 times, most recently from 456ce92 to 69c1417 Compare June 19, 2023 08:47
@oeb25
Copy link

oeb25 commented Jun 19, 2023

Awesome! 👍

In regards to #448, I think this PR solves the issue for users of the older (i.e., "go read this instead"), while it unfortunately still doesn't avoid confusion for users of the new version.

@xffxff
Copy link
Member Author

xffxff commented Jun 20, 2023

In regards to #448, I think this PR solves the issue for users of the older (i.e., "go read this instead"), while it unfortunately still doesn't avoid confusion for users of the new version.

@oeb25 Yes, you're correct. This PR doesn't completely address issue #448. Therefore, I updated the PR's description from "close 448" to "related to 448". This means that the issue will not be closed when the PR is merged.

@DropDemBits DropDemBits mentioned this pull request Sep 13, 2023
@nikomatsakis
Copy link
Member

Thanks for your patience. I am slowly (slowly) coming back online here. This looks like a good start. It'd be nice to modify the book here to just have both versions, I suppose, rather than redirecting to an external site. How hard would that be?

@xffxff
Copy link
Member Author

xffxff commented Oct 29, 2023

It'd be nice to modify the book here to just have both versions, I suppose, rather than redirecting to an external site. How hard would that be?

@nikomatsakis I've set up the book to support both versions by utilizing URL paths: xxx/salsa2022 for the latest edition and xxx/salsa for the older one. You can review my deployed versions on Netlify:

To make this work on our repo, we'll need to modify the publish directory from book/book/html to book/versions

My build settings:

image

I lack the permissions to make this change, but I believe you can assist :)

@nikomatsakis
Copy link
Member

@xffxff this looks cool, yes, thank you! Let me look into making that change.

@nikomatsakis nikomatsakis merged commit 143cd8a into salsa-rs:master Nov 9, 2023
2 of 5 checks passed
@nikomatsakis
Copy link
Member

I updated the permissions and decided to throw the dice 🎲 and merge the PR. Let's see what happens!

@nikomatsakis
Copy link
Member

@xffxff

image

Any thoughts ;)

@nikomatsakis
Copy link
Member

Might be I need to modify the run netlify.sh too...?

@nikomatsakis
Copy link
Member

Never mind, I think I see the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants