Add missing syn feature requirement
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest commit (283ccda), any project that uses Salsa hits tons of internal errors within Salsa. That's because Salsa needs syn's `full` feature, which was removed from the Cargo.toml as part of the Salsa 3.0 mega-PR. Because Salsa 1.0 still has the `full` feature in its Cargo.toml, Cargo implicitly still enables `full` for Salsa 2022, and thus the Salsa 2022 example projects compile fine -- even though any external code using Salsa does not.
✅ Deploy Preview for salsa-rs canceled.
|
nikomatsakis
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest commit (283ccda), any project that uses Salsa hits tons
of internal errors within Salsa. That's because Salsa needs syn's
fullfeature, which was removed from the Cargo.toml as part of the Salsa 3.0
mega-PR. Because Salsa 1.0 still has the
fullfeature in itsCargo.toml, Cargo implicitly still enables
fullfor Salsa 2022, andthus the Salsa 2022 example projects compile fine -- even though any
external code using Salsa does not.