-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the old Salsa, rename salsa-2022
crate to salsa
#501
Conversation
✅ Deploy Preview for salsa-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Woohoo! |
cp _redirects versions | ||
mdbook build | ||
mkdir versions | ||
mv book/html/* versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only caveat here: I feel like maybe we should keep the older book for now. But I am happy to not have the complexity, maybe we can just "clone" the old book into the new book as a subdirectory for the time being or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Doesn't have to be done in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #503
> | ||
> This page describes the unreleased "Salsa 2022" version, which is a major departure from older versions of salsa. The code here works but is only available on github and from the `salsa-2022` crate. | ||
> | ||
> If you are looking for the older version of salsa, simply visit [this link](https://salsa-rs.netlify.app/salsa) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want some variant of this to indicate that it's not what is on crates.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #503
@@ -11,7 +11,9 @@ description = "Procedural macros for the salsa crate" | |||
proc-macro = true | |||
|
|||
[dependencies] | |||
eyre = "0.6.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use this? should probably look into that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #504
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in the lazy-input
example, but not in the macro crate. I'll put up a PR.
I'm going to go ahead and merge this because it seems like conflict hell |
Closes #493.