Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone dynamic and includes as service dependency #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Poil
Copy link

@Poil Poil commented Aug 10, 2018

I propose these changes :

  • Add the parameter "dynamic" to allow to not manage a zone if the file already exists
  • Add as service dependencies the "includes" parameter

…lready exists.

add includes as service dependancies
Copy link
Contributor

@aanriot aanriot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the includes, I think that it has to be discussed on #104 as the formula becomes more and more cryptic on my own advice. Moreover, we have to ensure that it will not break existing support for RedHat (https://github.com/saltstack-formulas/bind-formula/blob/master/bind/files/redhat/named.conf).

Regarding dynamic zones, have you tried to declare such zones as pillars in configured_zones? It sounds a bit similar.

@javierbertoli
Copy link
Member

@Poil did you have any time to check @aanriot 's comments? Also, perhaps using Salt's dynamic dns update makes sense for zones marked as dynamic, so we can add a state named dynamic.sls where we can manage records without breaking the zone's journal? (I mentioned this in the related issue #104)

@aanriot aanriot changed the title add zone dynamic and includes as service dependency Add zone dynamic and includes as service dependency Sep 10, 2018
@aanriot
Copy link
Contributor

aanriot commented Jan 3, 2019

@Poil , were you able to check this PR again? Thanks.

@Poil
Copy link
Author

Poil commented Jan 3, 2019

Sorry I had no time, I will try in the next week to check if it is possible or not to include a subfile for record, but I think it is not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants