fix: avoid setting multiple pre-start stanzas in upstart

[solarchad]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

Primary type

• [build] Changes related to the build system
• [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ci] Changes to the continuous integration configuration
• [feat] A new feature
• [fix] A bug fix
• [perf] A code change that improves performance
• [refactor] A code change that neither fixes a bug nor adds a feature
• [revert] A change used to revert a previous commit
• [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [docs] Documentation changes
• [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#238

Describe the changes you're proposing

This fixes a bug introduced in #238.

According to the upstart init manpages:

If a stanza is duplicated, the last occurence will be used.

So if someone has set both vars pull_before_start and remove_before_start to true, then there could be two pre-start script stanzas, of which upstart would only accept the last one, which isn't ideal behavior.

This change groups both scripts to run under one pre-start script stanza.

Pillar / config required to test the proposed changes

N/A

Debug log showing how the proposed changes work

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

[myii]

Merged, thanks for the quick fix, @solarchad.

[saltstack-formulas-travis]

🎉 This PR is included in version 0.43.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀