Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jobs): add jobs: {} to defaults and state to init #58

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

javierbertoli
Copy link
Member

@javierbertoli javierbertoli commented Jul 6, 2021

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Fixes #57

Describe the changes you're proposing

As suggested, added an empty default jobs dict and the jobs.sls state to the init.sls, so it's run without
the need to add it separately.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@javierbertoli javierbertoli requested a review from a team as a code owner July 6, 2021 23:58
@javierbertoli javierbertoli requested a review from dafyddj July 7, 2021 01:04
myii added a commit to myii/ssf-formula that referenced this pull request Jul 7, 2021
@myii myii merged commit 10fc44e into saltstack-formulas:master Jul 7, 2021
@myii
Copy link
Member

myii commented Jul 7, 2021

Merged, thanks @javierbertoli.

@saltstack-formulas-travis

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@daks
Copy link
Member

daks commented Aug 17, 2021

Nice, in fact the needs to include two states was very strange :)

Shouldn't the README be updated to explicitely state that the meta-state is sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include jobs.sls in init.sls?
4 participants