ci(kitchen+travis): replace EOL pre-salted images #148

myii · 2019-07-09T05:07:37Z

* Fedora:   30 => 29 & 29 => 28 (EOL)
* OpenSuse: 15 => 42 (EOL)
  - Use `dist: xenial` to prevent failures

* Include latest pre-salted images replacing EOL platforms - Ref: saltstack-formulas/template-formula#148

myii · 2019-07-10T18:06:58Z

Updated to include the new amazonlinux-2 images as well as debian-10 (develop only for the time being).

* Include latest pre-salted images replacing EOL platforms - Ref: saltstack-formulas/template-formula#148

daks · 2019-07-11T05:51:38Z

kitchen.yml

@@ -79,6 +88,9 @@ platforms:
    driver:
      image: netmanagers/salt-2018.3-py2:opensuse-leap-15
      run_command: /usr/lib/systemd/systemd
+  - name: amazonlinux-2-2018-3-py2
+    driver:
+      image: netmanagers/salt-2018.3-py2:amazonlinux-2

  ## SALT 2017.7
  - name: debian-8-2017-7-py2


See comment below.

daks · 2019-07-11T05:53:46Z

.travis.yml

-    # - INSTANCE: default-opensuse-leap-15-2018-3-py2
-    - INSTANCE: default-opensuse-leap-42-2018-3-py2
+    - INSTANCE: default-opensuse-leap-15-2018-3-py2
+    # - INSTANCE: default-amazonlinux-2-2018-3-py2
    # - INSTANCE: default-debian-8-2017-7-py2


You changed previous debian-9 to debian-10. I would have changed this debian-8 commented line instead.

Maybe also let debian-9 be tested and the new debian-10 recently released be tested too, keeping both for some time.

@daks Thanks for the suggestion. With so many images to choose from, it's always going to be hard to select 6 for the matrix! The general idea behind the Debian images was to have all of the supported versions represented at least once. So that became:

10 x 1

9 x 2

8 x 1

In terms of the matrix itself, we've now got 6 different platforms, so we need to use each one once. Since amazonlinux-2 was a straight swap with centos-7, that's what I did.

Ultimately, each formula can use it's own combination, so I'm not sure how to improve this without losing something else.

I would say that, even if it's still supported one year, Debian 8 is now the least critical to remove for Debian versions.

It might be easier to track the debian version from the saltstack repo, debian 10 packages are still a wip.

@javierbertoli I'd love to get your input on this discussion above.

I kinda agree with @daks, that we should keep them for a while, but also remember we don't need to use/enable them all as long as the relevant tests so a matrix:

latest os-deb, py3, git salt

latest os-rpm, py3, git salt

latest os-deb, py3, packaged salt

latest os-rpm, py3, packaged salt

previous os-deb, py2, packaged salt

previous os-rpm, py2, packaged salt

oldest os-deb, py2, packaged salt

oldest os-rpm, py2, packaged salt

would cover most of the relevant cases. I think that:

# latest os-deb, py3, git salt - INSTANCE: default-debian-10-develop-py3 # - INSTANCE: default-ubuntu-1804-develop-py3 # - INSTANCE: default-centos-7-develop-py3 # latest os-rpm, py3, git salt - INSTANCE: default-fedora-30-develop-py3 # - INSTANCE: default-opensuse-leap-15-develop-py3 # - INSTANCE: default-amazonlinux-2-develop-py2 # - INSTANCE: default-debian-9-2019-2-py3 # latest os-deb, py3, packaged salt - INSTANCE: default-ubuntu-1804-2019-2-py3 # latest os-rpm, py3, packaged salt - INSTANCE: default-centos-7-2019-2-py3 # - INSTANCE: default-fedora-30-2019-2-py3 # - INSTANCE: default-opensuse-leap-15-2019-2-py3 # - INSTANCE: default-amazonlinux-2-2019-2-py2 # previous os-deb, py2, packaged salt - INSTANCE: default-debian-9-2018-3-py2 # - INSTANCE: default-ubuntu-1604-2018-3-py2 # - INSTANCE: default-centos-7-2018-3-py2 # - INSTANCE: default-fedora-29-2018-3-py2 # previous os-rpm, py2, packaged salt - INSTANCE: default-opensuse-leap-15-2018-3-py2 # - INSTANCE: default-amazonlinux-2-2018-3-py2 # oldest os-deb, py2, packaged salt - INSTANCE: default-debian-8-2017-7-py2 # - INSTANCE: default-ubuntu-1604-2017-7-py2 # oldest os-rpm, py2, packaged salt - INSTANCE: default-centos-6-2017-7-py2 # - INSTANCE: default-fedora-29-2017-7-py2 # - INSTANCE: default-opensuse-leap-15-2017-7-py2 # - INSTANCE: default-amazonlinux-2-2017-7-py2

might satisfy those cases?

@javierbertoli that would cover most OSes and derivatives

@daks @aboe76 @javierbertoli Can we reach a decision on this soon? The first stage of PRs to standardise the files has almost completed (thanks to you all for your reviews and merges). The second stage will depend on this decision; I've also got a users-formula PR waiting in the wings.

Actually, there is another way: we could wait for me to get ssf-formula out there and then have a PR there to make this final decision. Perhaps that would be even better, since all the PRs would be triggered from a PR merge in that formula...

So another question: I've been considering where to put this ssf-formula repo. I don't want to be presumptuous and put it into this org immediately. I was thinking to start the repo in my account and test it out for a few more iterations. Then we could decide to bring it across at the right time. What do you think?

@myii looks fine to put this tool in your personal account (that's where I looked for it :) at least for now. Then we could move it to org.

About the images list, the one from @javierbertoli looks fine.

@daks Thanks for the feedback, I'll start the repo in my account, as planned.

In terms of the matrix, a few queries:

How about representing the new amazonlinux images we have?

I thought we agreed to limit ourselves to no more than 6 images per formula -- as I pushed through all of the PRs with ssf-formula, there was a logjam for an hour or two.

We have an exception on the vault-formula, where we're keeping hold of a platform that still uses upstart -- is it worth ensuring we have one of these in the matrix as well, such as an Ubuntu-14.04 (which is still under support for a while yet)?

* Fedora: 30 => 29 & 29 => 28 (EOL) * OpenSuse: 15 => 42 (EOL) - Use `dist: xenial` to prevent failures Squashed commits: * ci(kitchen+travis): add new `amazonlinux-2` pre-salted images * ci(kitchen+travis): use new `debian-10` pre-salted image for `develop`

myii · 2019-07-30T08:22:09Z

Rebased and squashed after merging #153.

aboe76 · 2019-07-30T14:04:00Z

@myii shall I merge this?

myii · 2019-07-30T14:25:36Z

@aboe76 I'm in no hurry now since merging #153. I'm going to share the ssf-formula soon and it can be discussed there, since we can compare the effects on all of the other formulas as well.

myii · 2019-08-05T16:24:00Z

@aboe76 Actually, would you mind merging this? Then it will match the current state of ssf-formula and the new semantic-release PRs that I've prepared.

myii · 2019-08-05T16:24:42Z

We can always resolve this via. ssf-formula afterwards, easily.

myii · 2019-08-06T09:16:22Z

Thanks @aboe76 for the merge. I'll ping you all for the discussion about (propagating) this using the ssf-formula. Then we can finalise the matrix as required.

saltstack-formulas-travis · 2019-08-06T12:22:47Z

🎉 This PR is included in version 3.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* Based on the discussions in the following merged PR: - saltstack-formulas/template-formula#148

myii · 2019-08-28T05:45:59Z

The plan is to use myii/ssf-formula#16 to propagate the changes to all of the repos.

* Based on the discussions in the following merged PR: - saltstack-formulas/template-formula#148 * Applied changes to all relevant formulas except the `ufw-formula`: - Some underlying problem there causing failures - Perhaps related to still needing to use `dist: trusty` (Travis)

myii requested a review from javierbertoli July 9, 2019 05:08

myii added a commit to myii/mysql-formula that referenced this pull request Jul 9, 2019

feat(semantic-release): implement for this formula

c97b956

* Include latest pre-salted images replacing EOL platforms - Ref: saltstack-formulas/template-formula#148

myii mentioned this pull request Jul 9, 2019

feat(semantic-release): implement for this formula saltstack-formulas/mysql-formula#220

Merged

myii added a commit to myii/mysql-formula that referenced this pull request Jul 10, 2019

feat(semantic-release): implement for this formula

e670547

* Include latest pre-salted images replacing EOL platforms - Ref: saltstack-formulas/template-formula#148

myii added a commit to myii/mysql-formula that referenced this pull request Jul 10, 2019

feat(semantic-release): implement for this formula

1d2e2f5

* Include latest pre-salted images replacing EOL platforms - Ref: saltstack-formulas/template-formula#148

daks reviewed Jul 11, 2019

View reviewed changes

myii force-pushed the ci/replace-eol-pre-salted-images branch 2 times, most recently from 43fcfb6 to 0d6fbf4 Compare July 19, 2019 21:05

myii mentioned this pull request Jul 30, 2019

chore: use semantic-release cross-formula standard structure #153

Merged

myii force-pushed the ci/replace-eol-pre-salted-images branch from 0d6fbf4 to 42ab22c Compare July 30, 2019 08:21

aboe76 merged commit a60ee2e into saltstack-formulas:develop Aug 6, 2019

myii deleted the ci/replace-eol-pre-salted-images branch August 6, 2019 09:15

saltstack-formulas-travis added the released label Aug 6, 2019

myii added a commit to myii/ssf-formula that referenced this pull request Aug 28, 2019

feat(formulas): replace EOL pre-salted images

e97281a

* Based on the discussions in the following merged PR: - saltstack-formulas/template-formula#148

myii mentioned this pull request Aug 28, 2019

feat(formulas): replace EOL pre-salted images myii/ssf-formula#16

Merged

myii mentioned this pull request Aug 28, 2019

ci(kitchen+travis): replace EOL pre-salted images saltstack-formulas/vault-formula#39

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(kitchen+travis): replace EOL pre-salted images #148

ci(kitchen+travis): replace EOL pre-salted images #148

myii commented Jul 9, 2019

myii commented Jul 10, 2019

daks Jul 11, 2019 •

edited

Loading

daks Jul 11, 2019

myii Jul 11, 2019

daks Jul 11, 2019

aboe76 Jul 12, 2019

myii Jul 12, 2019

javierbertoli Jul 13, 2019 •

edited

Loading

aboe76 Jul 15, 2019

myii Jul 24, 2019

daks Jul 24, 2019

myii Jul 24, 2019 •

edited

Loading

myii commented Jul 30, 2019

aboe76 commented Jul 30, 2019

myii commented Jul 30, 2019

myii commented Aug 5, 2019

myii commented Aug 5, 2019

myii commented Aug 6, 2019

saltstack-formulas-travis commented Aug 6, 2019

myii commented Aug 28, 2019

ci(kitchen+travis): replace EOL pre-salted images #148

ci(kitchen+travis): replace EOL pre-salted images #148

Conversation

myii commented Jul 9, 2019

myii commented Jul 10, 2019

daks Jul 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javierbertoli Jul 13, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

myii Jul 24, 2019 • edited Loading

Choose a reason for hiding this comment

myii commented Jul 30, 2019

aboe76 commented Jul 30, 2019

myii commented Jul 30, 2019

myii commented Aug 5, 2019

myii commented Aug 5, 2019

myii commented Aug 6, 2019

saltstack-formulas-travis commented Aug 6, 2019

myii commented Aug 28, 2019

daks Jul 11, 2019 •

edited

Loading

javierbertoli Jul 13, 2019 •

edited

Loading

myii Jul 24, 2019 •

edited

Loading