fix(osfingermap): avoid MaxPermSize on Amazon & Fedora 36 (use pillars_from_directories to fix CI)
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service doesn't start due to this:
```
× tomcat.service - Apache Tomcat Web Application Container
Loaded: loaded (/usr/lib/systemd/system/tomcat.service; enabled; vendor preset: disabled)
Active: failed (Result: exit-code) since Mon 2022-04-11 15:28:05 UTC; 4min 9s ago
Main PID: 538 (code=exited, status=1/FAILURE)
...: main class used: org.apache.catalina.startup.Bootstrap
...: flags used: -Djava.awt.headless=true -Xmx128m -XX:MaxPermSize=256m -Dlog4j.configuration=file:/tmp/log4j.properti>
...: options used: -Dcatalina.base=/usr/share/tomcat -Dcatalina.home=/usr/share/tomcat -Djava.endorsed.dirs= -Djava.io>
...: arguments used: start
...: NOTE: Picked up JDK_JAVA_OPTIONS: --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL->
...: Unrecognized VM option 'MaxPermSize=256m'
...: Error: Could not create the Java Virtual Machine.
...: Error: A fatal exception has occurred. Program will exit.
...: tomcat.service: Main process exited, code=exited, status=1/FAILURE
...: tomcat.service: Failed with result 'exit-code'.
```
* Semi-automated using myii/ssf-formula#430
myii
force-pushed
the
fix/avoid-MaxPermSize-on-Amazon-and-Fedora-36
branch
from
e05d2a9 to
e6fa640
Compare
|
🎉 This PR is included in version 0.19.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
pillars_from_directories& testpillar/top.slsmyii/ssf-formula#430Describe the changes you're proposing
Without this, the service doesn't start:
Pillar / config required to test the proposed changes
As provided in the test pillar files.
Debug log showing how the proposed changes work
As seen in the CI.
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context