You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What need in multiple repo states why it can't be single state? And all other tricks like including state file as Jinja template and then using extend to declare requisites.
Why result of applying repo state is actually installed packages? I think it must only configure repository and it's all. Installation must be preformed in conf state, or may be even better in separate install state.
My thoughts on this:
Repository state can be simplified, local file with gpg-key can be removed, if you can fetch packages from official repository, you also can fetch gpg-key from it. If you are using your own or 3-rd party repository, you don't need this key at all.
Multiple zabbix.*.repo states can be simplified to single zabbix.repo old ones can be saved for compatibility. Extend can be done in installation state.
I think there is need to be single repo state, if you wan't use official repo - include it in top file, or run via state.sls. Another approach also can be used control usage of official repo via pillar, like in php-formula may be it's even better to control everything via pillar.
repo must not install anything except repository itself, package installation must be moved in conf or even better in separate install state.
The text was updated successfully, but these errors were encountered:
repo
states why it can't be single state? And all other tricks like including state file as Jinja template and then usingextend
to declare requisites.repo
state is actually installed packages? I think it must only configure repository and it's all. Installation must be preformed inconf
state, or may be even better in separateinstall
state.My thoughts on this:
zabbix.*.repo
states can be simplified to singlezabbix.repo
old ones can be saved for compatibility. Extend can be done in installation state.repo
state, if you wan't use official repo - include it in top file, or run viastate.sls
. Another approach also can be used control usage of official repo via pillar, like in php-formula may be it's even better to control everything via pillar.repo
must not install anything except repository itself, package installation must be moved inconf
or even better in separateinstall
state.The text was updated successfully, but these errors were encountered: