Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGPO Module doesn't handle **Del and **DelVals properly #56062

Closed
twangboy opened this issue Feb 4, 2020 · 0 comments · Fixed by #56060
Closed

LGPO Module doesn't handle **Del and **DelVals properly #56062

twangboy opened this issue Feb 4, 2020 · 0 comments · Fixed by #56060
Assignees
Labels
Bug broken, incorrect, or confusing behavior P1 Priority 1 v3000.1 vulnerable version
Milestone

Comments

@twangboy
Copy link
Contributor

twangboy commented Feb 4, 2020

Description of Issue

The LGPO module will fail to enable some policies if they are set to disabled.

Setup

Set the following Group Policy Setting to Disabled:

Computer Policy->Administrative Templates->Windows Components->Windows Error Reporting->Configure Default consent

Steps to Reproduce Issue

Run the following state to enable the policy:

ERRORREP_config_default_consent:
  lgpo.set:
    - computer_policy:
        "Configure Default consent":
            "Consent level": 'Always ask before sending data'

The following will always be the result. The actual value never changes, even though there are no errors:

C:\Users\vagrant>salt-call --local state.apply test
[ERROR   ] policy WerDefaultConsent_1 was found but it does not appear to be valid for the class Machine
local:
----------
          ID: ERRORREP_config_default_consent
    Function: lgpo.set
      Result: True
     Comment: The following policies are in the correct state:
              Configure Default consent
     Started: 01:12:24.828000
    Duration: 2062.0 ms
     Changes:
Summary for local
------------
Succeeded: 1
Failed:    0
------------
Total states run:     1
Total run time:   2.062 s

Versions Report

Salt 3000

@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior team-windows labels Feb 5, 2020
@sagetherage sagetherage added this to the Approved milestone Feb 5, 2020
@sagetherage sagetherage linked a pull request Feb 5, 2020 that will close this issue
@sagetherage sagetherage added P1 Priority 1 ZRelease-Sodium retired label labels Feb 5, 2020
@sagetherage sagetherage added v3000.1 vulnerable version and removed ZRelease-Sodium retired label labels Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior P1 Priority 1 v3000.1 vulnerable version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants