win_lgpo - additional delvals fixes and string value fix #56569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
twangboy
previously approved these changes
Apr 17, 2020
|
@lomeroe Need to address the test failures (lint, docs, and pre-commit). And it probably needs a rebase... |
Ch3LL
previously requested changes
Aug 3, 2020
There was a problem hiding this comment.
any chance you can follow up on @twangboy 's comments here? #56569 (comment)
twangboy
force-pushed
the
fix_encode_and_splits
branch
from
7050232
to
575075c
Compare
|
@lomeroe I rebased and resolved some conflicts here... would you mind making sure I didn't mess this up? |
correct issue with ';' in text data
twangboy
force-pushed
the
fix_encode_and_splits
branch
from
f8de739
to
5b91abc
Compare
twangboy
added
Magnesium
twangboy
approved these changes
Oct 6, 2020
Ch3LL
approved these changes
Oct 7, 2020
|
@twangboy still looks okay to me, thanks for cleaning this up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports fixes from #56060 to other places where the delvals regex was searched.
Corrects an issue where a string value with a semicolon in it would only show the first value in the setting
Adds testing of policy returned from lgpo.get for each ADMX policy test
What issues does this PR fix or reference?
#56062
Previous Behavior
Some delvals items would show "**delvals" as the configuration instead of "Disabled"
Items with a semicolon in them (such as the "Enter fully qualified server names separated by semicolons" of "Point and Print Restrictions") would only show the entry up to the semicolon - subsequent runs of lgpo may then reset the value to the shortened string.
New Behavior
Delval items correctly display the policy setting in lgpo.get
Items with a semicolon show all entries
Tests written?
Yes
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.