Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new chroot module #50418

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Add new chroot module #50418

merged 1 commit into from
Nov 26, 2018

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Nov 7, 2018 •
edited
Loading

What does this PR do?

Add a new chroot module in saltstack.

Based on dockermod.call, this module implement an way to execute random salt modules inside a chroot environment.

Tests are included.

@aplanas aplanas force-pushed the fix_chroot branch 2 times, most recently from c5afd55 to 99265e5 Compare November 8, 2018 13:06
@aplanas
Copy link
Contributor Author

aplanas commented Nov 8, 2018

Ready for review. I decided not to include the sls call in the chroot code, as I really do not see as relevant as the one that we have in docker.

But if I find that the sls is indeed useful in this context, I will implement it.

@aplanas
Copy link
Contributor Author

aplanas commented Nov 8, 2018

Also note that the header is now under apache license. I copied it from the apache site [1]. If this is not correct, please, point me to a good one.

[1] https://www.apache.org/legal/src-headers.html

@cachedout
Copy link
Contributor

@aplanas No need for a source license in each individual file. The entire project is covered under Apache 2.0. It doesn't hurt to have it there, though.

cachedout
cachedout reviewed Nov 8, 2018
View reviewed changes
salt/modules/chroot.py Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
@aplanas aplanas force-pushed the fix_chroot branch 2 times, most recently from cecef4b to a90a81d Compare November 8, 2018 17:16
@aplanas aplanas mentioned this pull request Nov 14, 2018
Merged
isbm
isbm suggested changes Nov 14, 2018
View reviewed changes
salt/modules/chroot.py Outdated Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
salt/modules/chroot.py Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
salt/modules/chroot.py Outdated Show resolved Hide resolved
tests/unit/modules/test_chroot.py Outdated Show resolved Hide resolved
tests/unit/modules/test_chroot.py Outdated Show resolved Hide resolved
@aplanas aplanas force-pushed the fix_chroot branch 2 times, most recently from bc8709b to 395428c Compare November 14, 2018 16:53
@cachedout cachedout merged commit a53847f into saltstack:develop Nov 26, 2018
@aplanas aplanas deleted the fix_chroot branch November 27, 2018 09:56
aplanas added a commit to aplanas/salt-1 that referenced this pull request Jan 30, 2019
@aplanas
Backport of:
3ca915b 
saltstack/salt#49668

saltstack/salt#49669

saltstack/salt#49670

saltstack/salt#49803

saltstack/salt#49804

saltstack/salt#50126

saltstack/salt#50175

saltstack/salt#50302

saltstack/salt#50380

saltstack/salt#50396

saltstack/salt#50418

saltstack/salt#50452

saltstack/salt#50473

saltstack/salt#50541

saltstack/salt#50607

saltstack/salt#50635

saltstack/salt#50671

saltstack/salt#50706

saltstack/salt#50725

saltstack/salt#50801

saltstack/salt#50834

saltstack/salt#51074

saltstack/salt#51094

saltstack/salt#51135
@aplanas aplanas mentioned this pull request Jan 30, 2019
Closed
aplanas added a commit to aplanas/salt-1 that referenced this pull request Jan 30, 2019
@aplanas
Backport of:
d4f6435 
* blockdev: fix url from comment
saltstack/salt#49668

* Documentation: fix typo in "equivalent"
saltstack/salt#49669

* states_pt3: fix rST link format
saltstack/salt#49670

* parted: fix _validate_partition_boundary
saltstack/salt#49803

* parted: fix the ordering of list command
saltstack/salt#49804

* Fix lowpkg.diff documentation and parameter name
saltstack/salt#50126

* Add root parameter to useradd, shadow and groupadd
saltstack/salt#50175

* cmd: Add root parameter for wait and run states
saltstack/salt#50302

* systemd: add optional root parameter
saltstack/salt#50380

* service: SUSE is not based on sysvinit anymore
saltstack/salt#50396

* Add new chroot module
saltstack/salt#50418

* Add new module freezer
saltstack/salt#50452

* parted: support variable length output for print
saltstack/salt#50473

* btrfs: add all subvolume commands
saltstack/salt#50541

* file: update attributes for lsattr and chattr
saltstack/salt#50607

* btrfs: add new btrfs state
saltstack/salt#50635

* zypper: demote log from error to warning
saltstack/salt#50671

* blkid: add search by token
saltstack/salt#50706

* mount: add fstab_{present,absent} states
saltstack/salt#50725

* btrfs: add option to not set subvolumes as default
saltstack/salt#50801

* Add disk_set and disk_toggle functions, and update valid partition flags
saltstack/salt#50834

* disk: support setting FAT size for format_
saltstack/salt#51074

* cmdmod: add sysfs into the chroot
saltstack/salt#51094

* mount: cache blkid information
saltstack/salt#51135
aplanas added a commit to aplanas/salt-1 that referenced this pull request Feb 4, 2019
@aplanas
Backport of:
6ec4bbf 
* blockdev: fix url from comment
saltstack/salt#49668

* Documentation: fix typo in "equivalent"
saltstack/salt#49669

* states_pt3: fix rST link format
saltstack/salt#49670

* parted: fix _validate_partition_boundary
saltstack/salt#49803

* parted: fix the ordering of list command
saltstack/salt#49804

* Fix lowpkg.diff documentation and parameter name
saltstack/salt#50126

* Add root parameter to useradd, shadow and groupadd
saltstack/salt#50175

* cmd: Add root parameter for wait and run states
saltstack/salt#50302

* systemd: add optional root parameter
saltstack/salt#50380

* service: SUSE is not based on sysvinit anymore
saltstack/salt#50396

* Add new chroot module
saltstack/salt#50418

* Add new module freezer
saltstack/salt#50452

* parted: support variable length output for print
saltstack/salt#50473

* btrfs: add all subvolume commands
saltstack/salt#50541

* file: update attributes for lsattr and chattr
saltstack/salt#50607

* btrfs: add new btrfs state
saltstack/salt#50635

* zypper: demote log from error to warning
saltstack/salt#50671

* blkid: add search by token
saltstack/salt#50706

* mount: add fstab_{present,absent} states
saltstack/salt#50725

* btrfs: add option to not set subvolumes as default
saltstack/salt#50801

* Add disk_set and disk_toggle functions, and update valid partition flags
saltstack/salt#50834

* disk: support setting FAT size for format_
saltstack/salt#51074

* cmdmod: add sysfs into the chroot
saltstack/salt#51094

* mount: cache blkid information
saltstack/salt#51135
aplanas added a commit to aplanas/salt-1 that referenced this pull request Feb 4, 2019
@aplanas
Backport of:
1a6a43d 
* blockdev: fix url from comment
saltstack/salt#49668

* Documentation: fix typo in "equivalent"
saltstack/salt#49669

* states_pt3: fix rST link format
saltstack/salt#49670

* parted: fix _validate_partition_boundary
saltstack/salt#49803

* parted: fix the ordering of list command
saltstack/salt#49804

* Fix lowpkg.diff documentation and parameter name
saltstack/salt#50126

* Add root parameter to useradd, shadow and groupadd
saltstack/salt#50175

* cmd: Add root parameter for wait and run states
saltstack/salt#50302

* systemd: add optional root parameter
saltstack/salt#50380

* service: SUSE is not based on sysvinit anymore
saltstack/salt#50396

* Add new chroot module
saltstack/salt#50418

* Add new module freezer
saltstack/salt#50452

* parted: support variable length output for print
saltstack/salt#50473

* btrfs: add all subvolume commands
saltstack/salt#50541

* file: update attributes for lsattr and chattr
saltstack/salt#50607

* btrfs: add new btrfs state
saltstack/salt#50635

* zypper: demote log from error to warning
saltstack/salt#50671

* blkid: add search by token
saltstack/salt#50706

* mount: add fstab_{present,absent} states
saltstack/salt#50725

* btrfs: add option to not set subvolumes as default
saltstack/salt#50801

* Add disk_set and disk_toggle functions, and update valid partition flags
saltstack/salt#50834

* disk: support setting FAT size for format_
saltstack/salt#51074

* cmdmod: add sysfs into the chroot
saltstack/salt#51094

* mount: cache blkid information
saltstack/salt#51135
aplanas added a commit to aplanas/salt-1 that referenced this pull request Feb 4, 2019
@aplanas
Backport from develop features required by yomi
215d37b 
* blockdev: fix url from comment
saltstack/salt#49668

* Documentation: fix typo in "equivalent"
saltstack/salt#49669

* states_pt3: fix rST link format
saltstack/salt#49670

* parted: fix _validate_partition_boundary
saltstack/salt#49803

* parted: fix the ordering of list command
saltstack/salt#49804

* Fix lowpkg.diff documentation and parameter name
saltstack/salt#50126

* Add root parameter to useradd, shadow and groupadd
saltstack/salt#50175

* cmd: Add root parameter for wait and run states
saltstack/salt#50302

* systemd: add optional root parameter
saltstack/salt#50380

* service: SUSE is not based on sysvinit anymore
saltstack/salt#50396

* Add new chroot module
saltstack/salt#50418

* Add new module freezer
saltstack/salt#50452

* parted: support variable length output for print
saltstack/salt#50473

* btrfs: add all subvolume commands
saltstack/salt#50541

* file: update attributes for lsattr and chattr
saltstack/salt#50607

* btrfs: add new btrfs state
saltstack/salt#50635

* zypper: demote log from error to warning
saltstack/salt#50671

* blkid: add search by token
saltstack/salt#50706

* mount: add fstab_{present,absent} states
saltstack/salt#50725

* btrfs: add option to not set subvolumes as default
saltstack/salt#50801

* Add disk_set and disk_toggle functions, and update valid partition flags
saltstack/salt#50834

* disk: support setting FAT size for format_
saltstack/salt#51074

* cmdmod: add sysfs into the chroot
saltstack/salt#51094

* mount: cache blkid information
saltstack/salt#51135
aplanas added a commit to aplanas/salt-1 that referenced this pull request Feb 26, 2019
@aplanas
Backport from develop features required by yomi
e7ee1f1 
* blockdev: fix url from comment
saltstack/salt#49668

* Documentation: fix typo in "equivalent"
saltstack/salt#49669

* states_pt3: fix rST link format
saltstack/salt#49670

* parted: fix _validate_partition_boundary
saltstack/salt#49803

* parted: fix the ordering of list command
saltstack/salt#49804

* Fix lowpkg.diff documentation and parameter name
saltstack/salt#50126

* Add root parameter to useradd, shadow and groupadd
saltstack/salt#50175

* cmd: Add root parameter for wait and run states
saltstack/salt#50302

* systemd: add optional root parameter
saltstack/salt#50380

* service: SUSE is not based on sysvinit anymore
saltstack/salt#50396

* Add new chroot module
saltstack/salt#50418

* Add new module freezer
saltstack/salt#50452

* parted: support variable length output for print
saltstack/salt#50473

* btrfs: add all subvolume commands
saltstack/salt#50541

* file: update attributes for lsattr and chattr
saltstack/salt#50607

* btrfs: add new btrfs state
saltstack/salt#50635

* zypper: demote log from error to warning
saltstack/salt#50671

* blkid: add search by token
saltstack/salt#50706

* mount: add fstab_{present,absent} states
saltstack/salt#50725

* btrfs: add option to not set subvolumes as default
saltstack/salt#50801

* Add disk_set and disk_toggle functions, and update valid partition flags
saltstack/salt#50834

* disk: support setting FAT size for format_
saltstack/salt#51074

* cmdmod: add sysfs into the chroot
saltstack/salt#51094

* mount: cache blkid information
saltstack/salt#51135
@aplanas aplanas mentioned this pull request Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout left review comments

@isbm isbm isbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aplanas @cachedout @isbm