Add root and no_recommends parameters in the public interface for Zypper and RPM (lowpkg) #51409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 199f337)
(cherry picked from commit 6aae270)
The CLI rpm command allows the --root parameter to change the expected location where the rpm database can be found. This patch add a new optional parameter in the public interface to allow the set of the new root location. Update the tests to use the extra parameter. (cherry picked from commit 5747448)
The zypper CLI provides a way to change the path where zypper expect to find the required configuration files and repositories. This feature is useful to bootstrap chroot environments, inspect repositories and packages from locally mounted devices, or help during the installation of a new OS from the SUSE family. This patch add the root optional parameter for each command in the public interface, and fix the tests. (cherry picked from commit 1e57b30)
(cherry picked from commit 7430da8)
(cherry picked from commit ecdfb89)
_Zypper class take note when a .call() is done, to clean up the data when we access to some attribute. This produces a bug when two calls are one after another an we set some attributes via the __call__ method, as whatever is set will be cleared after the first attribute is accessed. For example: zypper.attrib.call(..) zypper(root=root).otherattrib.call(..) The first call will set __called as True, and the reset of the inner state of zypper will be cleared when otherattrib is accessed, cleanning the status for __root. This patch makes sure to clean the status also during the __call__ method, avoiding the cleanning when the attribute is accessed. (cherry picked from commit 50e549d)
Add no_recommends parameter to install and upgrade actions. (cherry picked from commit c2ace99)
In _get_configured_repos if the directory where the repositories are stored is not found, an log error is emitted. Most of the times this is indeed an indication of an error, but is not always the case. For example, when we are creating a chroot environment we do not need to create this directory, as is generated by zypper when a new repository is added. This patch demote the error to a warning, as this directory will be present eventually is most situations after the first call to zypper. (cherry picked from commit 441e116)
|
2019.2 has been feature frozen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides a new root parameter in the public interfaces for rpm and zypper
What issues does this PR fix or reference?
New feature
Tests written?
For the low level RPM yes, for the zypper level I adjusted the current tests.
(backport from #50125)
(backport from #50671)