Replace deprecated ifup, ifdown iface with ip link set iface up, down #52670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgreenaway
approved these changes
Apr 26, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces use of deprecated ifup and ifdown on Debian based systems (Debian and Ubuntu).
In Ubuntu 18.04.1 LTS, the use of ifupdown packages was removed and is not installed by default.
see url: https://wiki.ubuntu.com/BionicBeaver/ReleaseNotes/18.04.1#Network_configuration
Recommendation is to utilize ip link set iface up|down
What issues does this PR fix or reference?
see #49078
Previous Behavior
On a clean installed Ubuntu 18.04, failures using ifup or ifdown since package is not installed.
New Behavior
Removes dependency on ifup or ifdown and utilizes ip link set iface up or down
Tests written?
No, existing unit.modules.test_debian_ip suffices with test_down and test_up
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.