Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fully qualified cmd call #53311

Merged
merged 8 commits into from
Jun 17, 2019
Merged

Add fully qualified cmd call #53311

merged 8 commits into from
Jun 17, 2019

Conversation

doesitblend
Copy link
Collaborator

@doesitblend doesitblend commented May 30, 2019

What does this PR do?

Add full path to the CMD.exe call when creating a scheduled task to restart the Salt minion on Windows

What issues does this PR fix or reference?

Fixes #53306

Previous Behavior

Full path to the CMD command was not used causing some vulnerability scanners to list the Salt minion as a potential threat.

Tests written?

No

Commits signed with GPG?

Yes/No

@doesitblend doesitblend requested a review from twangboy May 30, 2019 03:51
@doesitblend doesitblend self-assigned this May 30, 2019
@twangboy twangboy added v2019.2 unsupported version ZRELEASED - Neon retired label labels Jun 17, 2019
@twangboy twangboy merged commit 12c769a into saltstack:develop Jun 17, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 26, 2019
twangboy added a commit to twangboy/salt that referenced this pull request Jul 26, 2019
dwoz added a commit that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2019.2 unsupported version ZRELEASED - Neon retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully Qualify CMD on Windows Minions
6 participants