-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Added bypass features to pkg.installed" #53347
Revert "Added bypass features to pkg.installed" #53347
Conversation
I checked that this is not currently in a release so it should be fine to revert. Since this is in develop we will need to backport to neon before we release there to ensure the feature is not released. |
@justindesilets this needs to be rebased against the master branch - or is there a different PR? |
@sagetherage this was just to revert a feature that had been merged in but was then later determined should be left out. Do I still actually need to debase this or can it just be merged in? |
@justindesilets good question - we are no longer accepting PRs against the |
@sagetherage I'm looking at the current master branch for the state/pkg.py and I don't see the bypass code in there. It looks like it was never merged in the transition from develop to master. I believe this PR can be closed at this point as there isn't a change to revert. |
Reverts #50922. It was determined that this was a duplicate function of another feature and less native to the salt method. I would like to revert it and will close out my current PR that has fixes in place for it here #53320. Additionally, I will open up a new PR in the next week to update the pkg.installed documentation to include how to use the unless feature with the aggregate feature.