Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added bypass features to pkg.installed" #53347

Closed
wants to merge 4 commits into from
Closed

Revert "Added bypass features to pkg.installed" #53347

wants to merge 4 commits into from

Conversation

justindesilets
Copy link

Reverts #50922. It was determined that this was a duplicate function of another feature and less native to the salt method. I would like to revert it and will close out my current PR that has fixes in place for it here #53320. Additionally, I will open up a new PR in the next week to update the pkg.installed documentation to include how to use the unless feature with the aggregate feature.

@Ch3LL Ch3LL added bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch ZRELEASED - Neon retired label labels Jun 26, 2019
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 26, 2019

I checked that this is not currently in a release so it should be fine to revert. Since this is in develop we will need to backport to neon before we release there to ensure the feature is not released.

@garethgreenaway garethgreenaway added ZRelease-Sodium retired label and removed ZRELEASED - Neon retired label labels Feb 14, 2020
@dwoz dwoz requested a review from a team as a code owner May 22, 2020 04:13
@ghost ghost requested review from twangboy and removed request for a team May 22, 2020 04:13
@sagetherage sagetherage added develop Pointing to develop branch; needs rebase and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels May 22, 2020
@sagetherage sagetherage removed the ZRelease-Sodium retired label label May 26, 2020
@sagetherage
Copy link
Contributor

@justindesilets this needs to be rebased against the master branch - or is there a different PR?

@justindesilets
Copy link
Author

@sagetherage this was just to revert a feature that had been merged in but was then later determined should be left out. Do I still actually need to debase this or can it just be merged in?

@sagetherage
Copy link
Contributor

@justindesilets good question - we are no longer accepting PRs against the develop branch, so if you want the change it needs to point to the active branch for changes = master

@justindesilets
Copy link
Author

@sagetherage I'm looking at the current master branch for the state/pkg.py and I don't see the bypass code in there. It looks like it was never merged in the transition from develop to master. I believe this PR can be closed at this point as there isn't a change to revert.

@twangboy twangboy mentioned this pull request Jun 27, 2020
@twangboy twangboy closed this Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Pointing to develop branch; needs rebase Reviewers-Assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants