Fix test suite on develop #53399
Merged
Fix test suite on develop #53399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ch3LL
added
bugfix-bckport
rares-pop
reviewed
Jun 7, 2019
rares-pop
approved these changes
Jun 10, 2019
waynew
approved these changes
Jun 14, 2019
|
@twangboy shouldn't these windows tests be passing then? 😝 |
|
@s0undt3ch The Windows tests are failing (I believe) because |
|
It needs #53409 merged |
cmcmarrow
approved these changes
Jun 14, 2019
Akm0d
approved these changes
Jun 14, 2019
Ch3LL
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tests aren't running because of some issues with the win_network util again... This should take care of it.
Tests written?
This fixes tests
Commits signed with GPG?
Yes