Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call potentially missing shade library #53734

Merged
merged 2 commits into from
Jul 6, 2019

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Jul 5, 2019

What does this PR do?

See title

What issues does this PR fix or reference?

#53012

@Akm0d Akm0d added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 6, 2019
@Akm0d Akm0d removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 6, 2019
@Akm0d Akm0d changed the title [WIP] Don't call potentially missing shade library Don't call potentially missing shade library Jul 6, 2019
@Akm0d Akm0d merged commit c18dfc8 into saltstack:develop Jul 6, 2019
@Akm0d Akm0d deleted the cloud_tests branch July 6, 2019 07:27
@Akm0d
Copy link
Contributor Author

Akm0d commented Jul 6, 2019

Doesn't need a new test case because this PR causes previously failing tests to pass.

@Akm0d Akm0d added v2019.2 unsupported version v2019.2.1 unsupported version labels Jul 8, 2019
@cmcmarrow cmcmarrow self-requested a review July 9, 2019 15:13
johnclyde pushed a commit to johnclyde/salt that referenced this pull request Aug 5, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 7, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 8, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
dwoz added a commit that referenced this pull request Aug 9, 2019
Don't call potentially missing shade library (#53734)
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 22, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Akm0d added a commit to Akm0d/salt that referenced this pull request Aug 22, 2019
* Check for openstack

* Account for HAS_SHADE not being a tuple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2019.2 unsupported version v2019.2.1 unsupported version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants