Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds webconfig tests #54069

Merged
merged 3 commits into from
Aug 23, 2019
Merged

adds webconfig tests #54069

merged 3 commits into from
Aug 23, 2019

Conversation

cmcmarrow
Copy link
Contributor

What does this PR do?

adds tests

What issues does this PR fix or reference?

https://github.com/saltstack/zh/issues/1454

Tests written?

Yes

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow requested a review from a team as a code owner July 30, 2019 21:34
@ghost ghost requested a review from Ch3LL July 30, 2019 21:34
Ch3LL
Ch3LL reviewed Jul 31, 2019
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how possible it is, but would it be easy to add some integration tests here as well?

@dwoz dwoz merged commit 706ee70 into saltstack:develop Aug 23, 2019
@garethgreenaway garethgreenaway mentioned this pull request Jul 31, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL left review comments

@twangboy twangboy twangboy approved these changes

@Akm0d Akm0d Akm0d approved these changes

@dwoz dwoz dwoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmcmarrow @dwoz @Ch3LL @Akm0d @twangboy