[master] Porting #50150 to master #54551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
garethgreenaway
changed the title
dwoz
requested changes
Oct 21, 2019
| ret['comment'] += 'Status {0} was not found, as specified.'.format(status) | ||
| ret['result'] = False | ||
| if status_type == 'string': | ||
| if data.get('status', '') == str(status): |
There was a problem hiding this comment.
Should this be str(data.get('status', '')) == str(status)? Assuming so, we should have a test for this case.
|
I believe there is no need to backport this PR, because it was included into #55145 |
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #50150 to master