Add firewall and SSH keys to Vultr #54913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
richardsimko
force-pushed
the
dev/improve-cloud-vultr
branch
3 times, most recently
from
c68433a to
ff3b663
Compare
richardsimko
changed the title
|
@richardsimko Please re-open this PR against |
richardsimko
force-pushed
the
dev/improve-cloud-vultr
branch
from
ff3b663 to
8bbd1e1
Compare
|
@dwoz Done! |
richardsimko
force-pushed
the
dev/improve-cloud-vultr
branch
from
8bbd1e1 to
94eaf27
Compare
|
@dwoz When can this be reviewed and merged? :) |
richardsimko
force-pushed
the
dev/improve-cloud-vultr
branch
from
a3d946c to
7820e6a
Compare
|
Hey @twangboy or whoever needs to review, I am really hanging out for this feature! Would love to help if anything else needs to be done to get this in! |
|
I'm going to close this PR and resubmit it in the hopes to get some attention. It's been here nearly a year now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the Vultr provider for Salt Cloud by adding options for
firewallgroupid(#53677) and SSH keys.What issues does this PR fix or reference?
#53677
Tests written?
No, there were no tests for these functions earlier. If there is a way to mock the integration towards Vultr I'm happy to write them.
Commits signed with GPG?
Yes