Adds enabled kwarg #55203
Merged
Adds enabled kwarg #55203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptpkg is using the keyword argument 'disabled', while zypper and yum are using enabled. This change allows to also pass 'disabled' to mod_repo from the aptpkg module.
ghost
requested a review
from 
|
@saltstack/team-core @cmcmarrow Could someone please take a look here? Thanks! |
|
There's 2 lint issues to address. |
|
@s0undt3ch Sorry, totally missed that. I've pushed a change and solved a conflict. Hopefully it's looking better now. |
|
No worries, though, the lint issues still exist. |
|
@s0undt3ch Ah, sorry. Seems like I overlooked that completely! 🤦♂️ |
dwoz
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
aptpkg is using the keyword argument 'disabled', while zypper and
yum are using enabled. This change allows to also pass 'disabled'
to mod_repo from the aptpkg module.
What issues does this PR fix or reference?
Previous Behavior
pkg.mod_repowould only be used withdisabled=True.New Behavior
pkg.mod_repocan now also be used withenabled=False.Tests written?
Yes
Commits signed with GPG?
Yes