Deprecate quiet kwarg in cmd.run state module

[Ch3LL]

What does this PR do?

Deprecate quiet kwarg in cmd.run state module

What issues does this PR fix or reference?

#49422

Previous Behavior

You could pass the kwarg quiet: True to the cmd.run state module.

New Behavior

You can no longer use quiet: True in the cmd.run state module and need to use output_loglevel: quiet instead.

Tests written?

Yes

Commits signed with GPG?

Yes

[dwoz]

@Ch3LL Are the cmdmod test failures related?

[Ch3LL]

yes they are. looks like TestsLoggingHandler got renamed to TstSuiteLoggingHandler in a recent PR merge here: #55533 so it was not able to load the test module. Just pushed a fix, we will see how this goes :)

[codecov]

Codecov Report

Merging #55573 into master will increase coverage by 20.44%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #55573       +/-   ##
===========================================
+ Coverage    18.8%   39.23%   +20.44%     
===========================================
  Files         818     1466      +648     
  Lines      175220   259860    +84640     
  Branches    37597    56309    +18712     
===========================================
+ Hits        32937   101938    +69001     
- Misses     139601   146713     +7112     
- Partials     2682    11209     +8527

Flag	Coverage Δ
#archlts	?
#centos7	?
#debian9	37.86% <ø> (?)
#macosxmojave	37% <ø> (?)
#proxy	?
#py2	38.54% <ø> (+19.94%)	⬆️
#py3	38.32% <ø> (+19.9%)	⬆️
#runtests	39.23% <ø> (+20.44%)	⬆️
#ubuntu1604	38.54% <ø> (+14.85%)	⬆️
#zeromq	39.23% <ø> (+20.44%)	⬆️

Impacted Files	Coverage Δ
salt/states/cmd.py	69.43% <ø> (ø)
salt/modules/dummyproxy_service.py	46.16% <0%> (-35.89%)	⬇️
salt/modules/dummyproxy_pkg.py	38.64% <0%> (-22.72%)	⬇️
salt/grains/philips_hue.py	58.83% <0%> (-11.76%)	⬇️
salt/executors/docker.py	44.45% <0%> (-11.11%)	⬇️
salt/grains/chronos.py	66.67% <0%> (-11.11%)	⬇️
salt/grains/junos.py	50% <0%> (-7.69%)	⬇️
salt/metaproxy/proxy.py	14.68% <0%> (-6.42%)	⬇️
salt/modules/pacmanpkg.py	25% <0%> (-4.95%)	⬇️
salt/modules/celery.py	36.37% <0%> (-3.63%)	⬇️
... and 1213 more

[codecov]

Codecov Report

Merging #55573 into master will increase coverage by 20.44%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #55573       +/-   ##
===========================================
+ Coverage    18.8%   39.23%   +20.44%     
===========================================
  Files         818     1466      +648     
  Lines      175220   259860    +84640     
  Branches    37597    56309    +18712     
===========================================
+ Hits        32937   101938    +69001     
- Misses     139601   146713     +7112     
- Partials     2682    11209     +8527

Flag	Coverage Δ
#archlts	?
#centos7	?
#debian9	37.86% <ø> (?)
#macosxmojave	37% <ø> (?)
#proxy	?
#py2	38.54% <ø> (+19.94%)	⬆️
#py3	38.32% <ø> (+19.9%)	⬆️
#runtests	39.23% <ø> (+20.44%)	⬆️
#ubuntu1604	38.54% <ø> (+14.85%)	⬆️
#zeromq	39.23% <ø> (+20.44%)	⬆️

Impacted Files	Coverage Δ
salt/states/cmd.py	69.43% <ø> (ø)
salt/modules/dummyproxy_service.py	46.16% <0%> (-35.89%)	⬇️
salt/modules/dummyproxy_pkg.py	38.64% <0%> (-22.72%)	⬇️
salt/grains/philips_hue.py	58.83% <0%> (-11.76%)	⬇️
salt/executors/docker.py	44.45% <0%> (-11.11%)	⬇️
salt/grains/chronos.py	66.67% <0%> (-11.11%)	⬇️
salt/grains/junos.py	50% <0%> (-7.69%)	⬇️
salt/metaproxy/proxy.py	14.68% <0%> (-6.42%)	⬇️
salt/modules/pacmanpkg.py	25% <0%> (-4.95%)	⬇️
salt/modules/celery.py	36.37% <0%> (-3.63%)	⬇️
... and 1213 more