Fire events to all syndics from MoM when using tcp transport and syndic topology #55607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
lukasraska
force-pushed
the
fix-tcp-syndic
branch
from
2d60d0b
to
6bc152d
Compare
dwoz
approved these changes
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Properly fires events to syndics when using list targeting and master is configured with
order_mastersWhat issues does this PR fix or reference?
#55606
Previous Behavior
Jobs would timeout when executed from MoM using list targeting.
New Behavior
Jobs are received and executed on minions.
Tests written?
Yes
Commits signed with GPG?
Yes