Added a skip_files_list_verify argument to archive.extracted state #55700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Oloremo
force-pushed
the
55443-archive-hash-trust
branch
2 times, most recently
from
4ef9413 to
0f0e4ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #55700 +/- ##
==========================================
- Coverage 18.82% 18.81% -0.01%
==========================================
Files 819 819
Lines 175421 175243 -178
Branches 37622 37597 -25
==========================================
- Hits 33008 32953 -55
+ Misses 139758 139640 -118
+ Partials 2655 2650 -5
|
So I'm reducing code coverage of files I didn't even touch. That's my secret superpower! |
Oloremo
force-pushed
the
55443-archive-hash-trust
branch
from
0f0e4ef to
b55087a
Compare
Oloremo
commented
Dec 20, 2019
Oloremo
force-pushed
the
55443-archive-hash-trust
branch
from
b55087a to
514aa40
Compare
Oloremo
commented
Dec 21, 2019
| @@ -533,7 +553,7 @@ def extracted(name, | |||
| then re-create that directory before extracting. Note that ``clean`` | |||
| and ``clean_parent`` are mutually exclusive. | |||
|
|
|||
| .. versionadded:: Sodium | |||
| .. versionadded:: Neon | |||
There was a problem hiding this comment.
not related to this PR, just a mistake from my previous one. I hope it's ok to fix it here too
|
I tested this logic on some scenarios like a remote source, local source, remote source hash, source_hash as a string - all seems good. Not sure about all possible edge cases - salt file caching is complicated. But this is an optional feature disabled by default so I hope it's ok. What I'm worried about in the docs. I'm not sure if I described it clearly. |
|
re-run full macosxmojave-py2 |
dwoz
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adding an ability to improve the archive.extracted state performance and traffic efficiency by adding an optional argument
skip_files_list_verifywhich will allow to skip the archive file list validation replacing it by checksum validation.What issues does this PR fix or reference?
#55443
Previous Behavior
Before that, it was a choice between re-downloading source every time OR keeping all archives sources in the cache without any ability to purge it efficiently.
New Behavior
Setting
skip_files_list_verifytoTruewill enforce the checksum check and if the checksums are match - we're done here.Tests written?
Yes
Commits signed with GPG?
Yes