Use encoding when caching pillar data #56143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from Fixes saltstack#51854 and ports saltstack#52195 to master
waynew
force-pushed
the
51854-minion-pillar-cache-exception
branch
from
074500f to
759290a
Compare
cmcmarrow
approved these changes
Feb 24, 2020
s0undt3ch
approved these changes
Feb 25, 2020
|
Fixes: #53943 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses sls encoding setting when caching pillar data (and ports #52195 to master)
What issues does this PR fix or reference?
Fixes #51854 and fixes #56121
Previous Behavior
It would always try to use
str, even though the file was opened in binary modeNew Behavior
Uses the SLS_ENCODING setting when dumping yaml pillar data to cache.
Tests written?
Yes
Commits signed with GPG?
Yes