-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only process ADMX files when loading policies #56310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needs some test coverage.
Added some tests |
Codecov Report
@@ Coverage Diff @@
## master #56310 +/- ##
=========================================
Coverage ? 17.41%
=========================================
Files ? 1234
Lines ? 232648
Branches ? 50745
=========================================
Hits ? 40517
Misses ? 189110
Partials ? 3021
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #56310 +/- ##
=========================================
Coverage ? 17.41%
=========================================
Files ? 1234
Lines ? 232648
Branches ? 50745
=========================================
Hits ? 40517
Misses ? 189110
Partials ? 3021
Continue to review full report at Codecov.
|
What does this PR do?
Fixes an issue with processing non ADMX files in the Policy Definitions directory.
What issues does this PR fix or reference?
https://gitlab.com/saltstack/enterprise/lock/issues/3826
Previous Behavior
lgpo.get_policy_info
would fail with the following stacktraceNew Behavior
Non-ADMX files are skipped, no stacktrace
Tests written?
Oui
Commits signed with GPG?
Yes