Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use virtualenv 20.0.10 for macosx tests #56360

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Mar 11, 2020

What does this PR do?

Running into this issue on mac tests: pypa/virtualenv#1581

There is a test that removes pip, and because of this issue with subproccess and virtualenv it uses the incorrect path and ends up removing the pip binary in the nox virtual environment and not the one created during the test run. This is fixed on mac with virtualenv version 20.0.10 hence upgrading the version here. Also had to make some updates to ensure the tests work with this new version.

This will fix the failing tests:

    integration.modules.test_pip.PipModuleTest.test_chained_requirements__non_absolute_file_path
    integration.modules.test_pip.PipModuleTest.test_issue_4805_nested_requirements
    integration.modules.test_pip.PipModuleTest.test_pip_install_multiple_editables_and_pkgs
    integration.modules.test_pip.PipModuleTest.test_requirements_as_list__non_absolute_file_path
    integration.modules.test_pip.PipModuleTest.test_requirements_as_list_of_chains__cwd_not_set__absolute_file_path
    integration.modules.test_pip.PipModuleTest.test_requirements_as_list_of_chains__cwd_set__absolute_file_path
    integration.modules.test_virtualenv_mod.VirtualenvModuleTest.test_create_defaults
    integration.modules.test_virtualenv_mod.VirtualenvModuleTest.test_site_packages
    integration.states.test_pip_state.PipStateTest.test_issue_2028_pip_installed_state
    integration.states.test_pip_state.PipStateTest.test_issue_2087_missing_pip
    integration.states.test_pip_state.PipStateTest.test_issue_6833_pip_upgrade_pip
    integration.states.test_pip_state.PipStateTest.test_pip_installed_errors
    integration.states.test_pip_state.PipStateTest.test_pip_installed_removed_venv
    integration.states.test_pip_state.PipStateTest.test_pip_installed_specific_env
    unit.states.test_pip_state.PipStateTest.test_install_requirements_parsing
    setUpClass (unit.modules.test_zcbuildout.BuildoutOnlineTestCase)
    setUpClass (unit.modules.test_zcbuildout.BuildoutTestCase)
    setUpClass (unit.states.test_zcbuildout.BuildoutTestCase)

What issues does this PR fix or reference?

#56342

@Ch3LL Ch3LL requested a review from a team as a code owner March 11, 2020 23:46
@ghost ghost requested a review from garethgreenaway March 11, 2020 23:46
@Ch3LL Ch3LL added the v3000.1 vulnerable version label Mar 12, 2020
@dwoz dwoz merged commit a660e96 into saltstack:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3000.1 vulnerable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants