-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mac build scripts #56435
Merged
Merged
Update mac build scripts #56435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56435 +/- ##
==========================================
- Coverage 18.4% 17.41% -1%
==========================================
Files 1271 1234 -37
Lines 249324 232701 -16623
Branches 54383 50760 -3623
==========================================
- Hits 45894 40528 -5366
+ Misses 199443 189269 -10174
+ Partials 3987 2904 -1083
Continue to review full report at Codecov.
|
s0undt3ch
force-pushed
the
update_mac_build_scripts
branch
from
March 23, 2020 22:09
c8e34ba
to
39bd545
Compare
s0undt3ch
force-pushed
the
update_mac_build_scripts
branch
from
March 23, 2020 22:36
39bd545
to
262ad2e
Compare
s0undt3ch
force-pushed
the
update_mac_build_scripts
branch
from
March 23, 2020 22:52
e2d378b
to
e6cc2a6
Compare
s0undt3ch
force-pushed
the
update_mac_build_scripts
branch
from
March 24, 2020 01:39
9ec4e8f
to
8fdf52a
Compare
dwoz
approved these changes
Mar 24, 2020
waynew
approved these changes
Mar 24, 2020
s0undt3ch
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Roll back #56417
Building on 10.14 seems to fix most of the issues
What issues does this PR fix or reference?
#56417
Tests written?
NA
Commits signed with GPG?
Yes