-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add win_wua.installed
to the win_wua module
#56637
Conversation
win_wua.installed
to the win_wua modulewin_wua.installed
to the win_wua module
ff22480
to
fc5fbd0
Compare
Can we get an associated issue with this PR? Also there are some failing doc and pre-commit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like online's documentation and the kwarg conflict. I'm not sure what is suppose to be the default but I was wondering if it will change teh default behavior for people using this module?
@Ch3LL There is no corresponding issue. It's a requirement for the VWin team. Going online is the default behavior. The ability to scan in an offline mode is part of the new feature. |
can we add one for tracking purposes? If someone wants to request the same feature, they will be able to see a feature request was already added. Also just a clarification question. it looks like you made the default for online to be True. Does this change default behavior for users? |
Online True was the default. This adds the ability to scan without going out to Microsoft or a WSUS server. |
Linked to Issue |
@xeacott That's actually for the |
Oh yeah, sorry put that in the wrong PR |
thanks for adding the issue @twangboy :) looks like there are some legit test failures here. |
6256c28
to
23dfd61
Compare
What does this PR do?
Adds
win_wua.installed
function to win_wua module. The function will return a list of updates that apply to the current build of Windows.What issues does this PR fix or reference?
Fixes: #56640
Previous Behavior
No way to get a list of installed updates
New Behavior
Now you can get a list of installed updates
Merge requirements satisfied?
Commits signed with GPG?
Yes