Initial POC of RabbitMQ transport #60753
Conversation
(work-in-progress, but looking for early feedback before the review gets too large). - there are a number of TODOs in this review; all should be addressed before review is ready for prime time - there are gaps in the implementation that will be addressed. This work is tracked in SSC-978 - a number of edge cases need to be tested/addressed (e.g. connection error recovery, etc.) - added functional tests - added integration tests Testing Done: functional tests with on master and one minion
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
|
|
||
| ZMQ's ipc transport not supported on Windows | ||
| """ | ||
| opts = dict(salt_master.config.copy(), ipc_mode="ipc", pub_hwm=0) | ||
| with PubServerChannelProcess(opts, salt_minion.config.copy()) as server_channel: | ||
| send_num = 10000 | ||
| send_num = 4 |
There was a problem hiding this comment.
I should undo this change. This number was reduced to easier testing and comparison of rabbitmq and zeromq.
…ransport is in POC; so we kip RMQ tests (for now) until RMQ dependencies are dealt with in the CI/CD pipeline.
…l". RMQ transport is in POC; so we skip RMQ tests (for now) until RMQ dependencies are dealt with in the CI/CD pipeline.
|
Closing in favour of #60775 |
What does this PR do?
Initial POC implementation of RabbitMQ as a new transport layer.
(work-in-progress, but looking for early feedback before the review gets too large).
Testing Done: functional tests with on master and one minion
What issues does this PR fix or reference?
Fixes: VMware SSC-978
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No