-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport refactor #61450
Transport refactor #61450
Conversation
20d9ab2
to
1ed3464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo left here, there was another typo I missed last time:
creates and runs an it's own ioloop.
probably should be
creates and runs it's own ioloop.
(or runs in it's own ioloop 🤷 )
Entirely non-blocking, of course 👍
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 1.75s - exit code: 1 Thanks again! |
What does this PR do?
Refactor transports to make them more plug-able. This PR adds the concept of channels to salt. Channels handle specifics related to salt such as message structure, authentication, ect. Transports are simplified to only handle sending and receiving messages over the wire.
What issues does this PR fix or reference?
Fixes: #61161
Superseeds: #60867
Merge requirements satisfied?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.