[master] Avoid use of deprecated net-tools and add support for ip neighbour #64351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
s0undt3ch
suggested changes
Jun 6, 2023
s0undt3ch
previously approved these changes
Jun 6, 2023
twangboy
previously approved these changes
Jun 6, 2023
Ch3LL
suggested changes
Jun 6, 2023
Ch3LL
previously approved these changes
Jun 6, 2023
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Megan Wilhite <mwilhite@vmware.com>
Co-authored-by: Megan Wilhite <mwilhite@vmware.com>
dmurphy18
force-pushed
the
net-tools-upd-57541
branch
from
bfb1d12 to
9d9226d
Compare
Ch3LL
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoids use of deprecated net-tools and add support for ip neighbour with IPv4 ip_neighs and IPv6 ip_neighs6, similar to ip_addrs and ip_addrs6
What issues does this PR fix or reference?
Fixes: #57541
New Behavior
Added support for ip neighbour with IPv4 ip_neighs and IPv6 ip_neighs6, and ensured that deprecated net-tools are no longer used when possible.
Also ported unittests to pytests and added tests for ip_neighs and ip_neighs6.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.