Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Ensure channels are closed on connection errors #65957

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 30, 2024

What does this PR do?

Any exceptions while connecting to a master will now ensure channels are cleaned up properly

What issues does this PR fix or reference?

Fixes: #65932

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested a review from a team as a code owner January 30, 2024 23:43
@dwoz dwoz requested review from whytewolf and removed request for a team January 30, 2024 23:43
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Ensure channels are closed on connection errors [3006.x] Ensure channels are closed on connection errors Jan 30, 2024
@dwoz dwoz added the test:full Run the full test suite label Jan 30, 2024
s0undt3ch
s0undt3ch previously approved these changes Jan 31, 2024
salt/minion.py Show resolved Hide resolved
salt/minion.py Show resolved Hide resolved
salt/minion.py Show resolved Hide resolved
@dwoz dwoz requested a review from s0undt3ch February 3, 2024 22:46
@s0undt3ch s0undt3ch merged commit d5b5191 into saltstack:3006.x Feb 6, 2024
818 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants