Fix: multiple logs enabled with a disabled account

saltsthlm · Nov 11, 2024 · 626285a · 626285a
1 parent f2e654e
commit 626285a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/EventSourcing.Test/AccountAggregateTest.cs b/EventSourcing.Test/AccountAggregateTest.cs
@@ -275,12 +275,12 @@ public async void Should_Add_Aditional_DeactivateEvent_ToAccountLog()
         new (
           Type: "DEACTIVATE",
           Message: "Account inactive for 270 days",
-          Timestamp: DateTime.Parse("2024-10-02T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-02T10:30:00")
         ),
         new (
           Type: "DEACTIVATE",
           Message: "Security alert: suspicious activity",
-          Timestamp: DateTime.Parse("2024-10-03T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-03T10:30:00")
         ),
       ]
     };
@@ -358,12 +358,12 @@ public async void ActivateEvent_Should_AddEventToAccountLog()
         new (
           Type: "DEACTIVATE",
           Message: "Account inactive for 270 days",
-          Timestamp: DateTime.Parse("2024-10-02T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-02T10:30:00")
         ),
         new (
           Type: "ACTIVATE",
           Message: "Account reactivated",
-          Timestamp: DateTime.Parse("2024-10-03T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-03T10:30:00")
         ),
       ]
     };
@@ -391,12 +391,12 @@ public async void ActivateEvent_ShouldNot_AddEventToAccountLog_IfAccountIsAlread
         new (
           Type: "DEACTIVATE",
           Message: "Account inactive for 270 days",
-          Timestamp: DateTime.Parse("2024-10-02T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-02T10:30:00")
         ),
         new (
           Type: "ACTIVATE",
           Message: "Account reactivated",
-          Timestamp: DateTime.Parse("2024-10-03T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-03T10:30:00")
         ),
       ]
     };
@@ -445,7 +445,7 @@ public async void ClosureEvent_Should_AddEventToAccountLog()
         new (
           Type: "CLOSURE",
           Message: "Reason: Customer request, Closing Balance: '5000'",
-          Timestamp: DateTime.Parse("2024-10-02T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-02T10:30:00")
         ),
       ]
     };
@@ -508,7 +508,7 @@ public async void CurrencyChangeEvent_Should_AddEventToAccountLog()
         new (
           Type: "CURRENCY-CHANGE",
           Message: "Change currency from 'USD' to 'SEK'",
-          Timestamp: DateTime.Parse("2024-10-02T10:30:00Z")
+          Timestamp: DateTime.Parse("2024-10-02T10:30:00")
         ),
       ]
     };

diff --git a/EventSourcing/AccountAggregate.cs b/EventSourcing/AccountAggregate.cs
@@ -84,13 +84,11 @@ private void Apply(WithdrawalEvent withdrawal)
   private void Apply(DeactivationEvent deactivation)
   {
     Status = AccountStatus.Disabled;
-    AccountLog = [
-        new (
-          Type: "DEACTIVATE",
-          Message: "Account inactive for 270 days",
-          Timestamp: DateTime.Parse("2024-10-02T10:30:00")
-        ),
-      ];
+    if (AccountLog == null)
+      AccountLog = new List<LogMessage>();
+    var logMessage = new LogMessage("DEACTIVATE", deactivation.Reason.ToString(), deactivation.Timestamp);
+    AccountLog.Add(logMessage);
+
   }
 
   private void Apply(ActivationEvent activation)