Create Windows tests #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pathlib.Path() and change from ubuntu-latest to Windows-latest
|
It appears that Windows handles the hidden char different than POSIX systems. |
|
closes #43 |
Moosems
added a commit
that referenced
this pull request
Jul 8, 2024
* Use 3.11 everywhere (#38) * v0.6.0 (#42) (#45) * Bump version and add note to README Prepare for release tomorrow and move forward for v0.7.0 and v0.8.0 release * Steal pygments regexes (#34) * test.py * Move to server functions and set up proper tests * Reformat * Reformat * Change to beartype typing * Even more formatting * Remove regex stealer test Runs different locally than on gh runner and not worth the time or effort. * Get docstring areas * Make function work * Add type annotation * format * Add lots of comments but don't remove private type @leycec I tried using the idea you gave for private types but got Union type errors for some reason I couldn't really understand. Thank you so much for your time and thoughts and congrats on the bike ride, thats a long stretch! * Fix a small bug * Improve highlighting functions significantly Now it ignores whitespace at the front of the line! * Stop using private variable * Format for black and ruff * Move docstring tokens up * Update tests * Fix line number for docstring tokens Was 1 behind * Reformat * Bump version * Implement token overwriting (#49) * Display the problem * Get working test * Better overlap checking * Better tests * Sort and remove duplicates * Remove old vestige and format * Move token merging to highlight file * Format * Use overwrite_and_merge_tokens * Use caches (#53) * Cache important functions * Remove old file * Format * Explain python version requirement plans (#54) * Tokens outside text range (#56) * Use 3.11 everywhere (#38) * v0.6.0 (#42) (#45) * Bump version and add note to README Prepare for release tomorrow and move forward for v0.7.0 and v0.8.0 release * Steal pygments regexes (#34) * test.py * Move to server functions and set up proper tests * Reformat * Reformat * Change to beartype typing * Even more formatting * Remove regex stealer test Runs different locally than on gh runner and not worth the time or effort. * Get docstring areas * Make function work * Add type annotation * format * Add lots of comments but don't remove private type @leycec I tried using the idea you gave for private types but got Union type errors for some reason I couldn't really understand. Thank you so much for your time and thoughts and congrats on the bike ride, thats a long stretch! * Fix a small bug * Improve highlighting functions significantly Now it ignores whitespace at the front of the line! * Stop using private variable * Format for black and ruff * Move docstring tokens up * Update tests * Fix line number for docstring tokens Was 1 behind * Reformat * Bump version * Implement token overwriting (#49) * Display the problem * Get working test * Better overlap checking * Better tests * Sort and remove duplicates * Remove old vestige and format * Move token merging to highlight file * Format * Use overwrite_and_merge_tokens * Use caches (#53) * Cache important functions * Remove old file * Format * Explain python version requirement plans (#54) * Check that all tokens are in text range * Create Windows tests (#57) * Start small Use pathlib.Path() and change from ubuntu-latest to Windows-latest * Format * Handle different Windows import * Fix server.py (same issue as last) * Update names * Try printing out returned tokens * Give both outputs * Update README to note the issue * Try breaking up different lines * Use bullet points * Refactor highlight (#58) * Change highlight code structure Moved into multiple separate files (could become a submodule) * Move to submodule
Moosems
commented
Jul 8, 2024
| ((3, 11), 7, "Comment"), | ||
| ((5, 0), 5, "Name"), | ||
| ((5, 5), 1, "Punctuation"), | ||
| ((5, 6), 5, "String"), |
There was a problem hiding this comment.
Note that the hidden char takes up three character widths instead of one and that the hidden char was not found in the text (https://github.com/Moosems/salve/blob/c7ef978121213f21143a614a9de65434c486bdba/salve_ipc/server_functions/highlight/links_and_hidden_chars.py#L99-L109)
| ((17, 0), 3, "Name"), | ||
| ((17, 3), 2, "Punctuation"), | ||
| ((18, 0), 24, "Comment"), | ||
| ((18, 2), 22, "Link"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.