Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade derive-syn-parse #14

Merged
merged 3 commits into from
Jul 4, 2024
Merged

upgrade derive-syn-parse #14

merged 3 commits into from
Jul 4, 2024

Conversation

jmg-duarte
Copy link
Contributor

This makes the crate not rely on syn version 1

Details

Before this change:

[16:18:37] Φ cargo tree                                                
macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic)
└── macro_magic_macros v0.5.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/macros)
    ├── macro_magic_core v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic/core)
    │   ├── const-random v0.1.18
    │   │   └── const-random-macro v0.1.16 (proc-macro)
    │   │       ├── getrandom v0.2.15
    │   │       │   ├── cfg-if v1.0.0
    │   │       │   └── libc v0.2.155
    │   │       ├── once_cell v1.19.0
    │   │       └── tiny-keccak v2.0.2
    │   │           └── crunchy v0.2.2
    │   ├── derive-syn-parse v0.1.5 (proc-macro)
    │   │   ├── proc-macro2 v1.0.86
    │   │   │   └── unicode-ident v1.0.12
    │   │   ├── quote v1.0.36
    │   │   │   └── proc-macro2 v1.0.86 (*)
    │   │   └── syn v1.0.109 <------------------------------- here
    │   │       ├── proc-macro2 v1.0.86 (*)
    │   │       ├── quote v1.0.36 (*)
    │   │       └── unicode-ident v1.0.12
    │   ├── macro_magic_core_macros v0.5.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/core_macros)
    │   │   ├── proc-macro2 v1.0.86 (*)
    │   │   ├── quote v1.0.36 (*)
    │   │   └── syn v2.0.68
    │   │       ├── proc-macro2 v1.0.86 (*)
    │   │       ├── quote v1.0.36 (*)
    │   │       └── unicode-ident v1.0.12
    │   ├── proc-macro2 v1.0.86 (*)
    │   ├── quote v1.0.36 (*)
    │   └── syn v2.0.68 (*)
    ├── quote v1.0.36 (*)
    └── syn v2.0.68 (*)
[dev-dependencies]
├── external_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/external_crate)
│   └── macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic) (*)
├── isolated_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/isolated_crate)
│   └── middle_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/middle_crate)
│       ├── macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic) (*)
│       └── test_macros v0.1.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/tests/test_macros)
│           ├── derive-syn-parse v0.1.5 (proc-macro) (*)
│           ├── macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic)
│           │   ├── macro_magic_core v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic/core) (*)
│           │   ├── macro_magic_macros v0.5.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/macros) (*)
│           │   ├── quote v1.0.36 (*)
│           │   └── syn v2.0.68 (*)
│           │   [dev-dependencies]
│           │   ├── external_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/external_crate) (*)
│           │   ├── isolated_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/isolated_crate) (*)
│           │   ├── middle_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/middle_crate) (*)
│           │   └── test_macros v0.1.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/tests/test_macros) (*)
│           ├── proc-macro2 v1.0.86 (*)
│           ├── quote v1.0.36 (*)
│           └── syn v2.0.68 (*)
├── middle_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/middle_crate) (*)
└── test_macros v0.1.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/tests/test_macros) (*)

After

cargo tree
macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic)
└── macro_magic_macros v0.5.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/macros)
    ├── macro_magic_core v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic/core)
    │   ├── const-random v0.1.18
    │   │   └── const-random-macro v0.1.16 (proc-macro)
    │   │       ├── getrandom v0.2.15
    │   │       │   ├── cfg-if v1.0.0
    │   │       │   └── libc v0.2.155
    │   │       ├── once_cell v1.19.0
    │   │       └── tiny-keccak v2.0.2
    │   │           └── crunchy v0.2.2
    │   ├── derive-syn-parse v0.2.0 (proc-macro)
    │   │   ├── proc-macro2 v1.0.86
    │   │   │   └── unicode-ident v1.0.12
    │   │   ├── quote v1.0.36
    │   │   │   └── proc-macro2 v1.0.86 (*)
    │   │   └── syn v2.0.68
    │   │       ├── proc-macro2 v1.0.86 (*)
    │   │       ├── quote v1.0.36 (*)
    │   │       └── unicode-ident v1.0.12
    │   ├── macro_magic_core_macros v0.5.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/core_macros)
    │   │   ├── proc-macro2 v1.0.86 (*)
    │   │   ├── quote v1.0.36 (*)
    │   │   └── syn v2.0.68 (*)
    │   ├── proc-macro2 v1.0.86 (*)
    │   ├── quote v1.0.36 (*)
    │   └── syn v2.0.68 (*)
    ├── quote v1.0.36 (*)
    └── syn v2.0.68 (*)
[dev-dependencies]
├── external_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/external_crate)
│   └── macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic) (*)
├── isolated_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/isolated_crate)
│   └── middle_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/middle_crate)
│       ├── macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic) (*)
│       └── test_macros v0.1.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/tests/test_macros)
│           ├── derive-syn-parse v0.2.0 (proc-macro) (*)
│           ├── macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic)
│           │   ├── macro_magic_core v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic/core) (*)
│           │   ├── macro_magic_macros v0.5.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/macros) (*)
│           │   ├── quote v1.0.36 (*)
│           │   └── syn v2.0.68 (*)
│           │   [dev-dependencies]
│           │   ├── external_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/external_crate) (*)
│           │   ├── isolated_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/isolated_crate) (*)
│           │   ├── middle_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/middle_crate) (*)
│           │   └── test_macros v0.1.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/tests/test_macros) (*)
│           ├── proc-macro2 v1.0.86 (*)
│           ├── quote v1.0.36 (*)
│           └── syn v2.0.68 (*)
├── middle_crate v0.1.0 (/Users/jmgd/Documents/Eiger/macro_magic/tests/middle_crate) (*)
└── test_macros v0.1.0 (proc-macro) (/Users/jmgd/Documents/Eiger/macro_magic/tests/test_macros) (*)

macro_magic v0.5.0 (/Users/jmgd/Documents/Eiger/macro_magic) (*)

This makes the crate not rely on `syn` version 1
@sam0x17
Copy link
Owner

sam0x17 commented Jul 3, 2024

this is great thank you, will probably cut a release tonight but bump this if it looks like I've forgotten!

@sam0x17
Copy link
Owner

sam0x17 commented Jul 3, 2024

ah no, manifest fails to parse

@jmg-duarte
Copy link
Contributor Author

ah no, manifest fails to parse

Yeah, I started by trying to make them all use the workspace dependencies and gave up but that change passed. Fixed now

@sam0x17
Copy link
Owner

sam0x17 commented Jul 3, 2024

ah no, manifest fails to parse

Yeah, I started by trying to make them all use the workspace dependencies and gave up but that change passed. Fixed now

yeah I think it would have broken with crates.io deploy anyway

@sam0x17
Copy link
Owner

sam0x17 commented Jul 3, 2024

now just some minor test case updates due to the changed tokenstream.to_string() output in syn 2 @jmg-duarte

@sam0x17 sam0x17 merged commit 7b938a4 into sam0x17:main Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants