images: support a SAMBACC_VERSION_SUFFIX to force a sambacc version #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the sambacc install script, when installing sambacc from a rpm repo with dnf, allow the caller to specify a version suffix in order to restrict the install to a particular version. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Add a SAMBACC_VERSION_SUFFIX variable like the SAMBA_VERSION_SUFFIX variable to support requiring a particular sambacc version. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous release we made sure to "pin" a version of both sambacc and samba. The former was done by an "embedded" build which is something we've moved away from. So this adds back the ability to require a sambacc version in a way more similar to how we previously required a samba version.