-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume nightly built Samba RPMs #50
Consume nightly built Samba RPMs #50
Conversation
19bfc9e
to
e565481
Compare
test-ad-server-kubernetes failed because we don't have AD DC components built with our nightly Samba RPMs. I'll enable and check. |
This looks very interesting, however I am not sure about adding the nightlies to our primary container file. What do you think? |
Make sense. I'll come up with the required changes. |
e565481
to
40be868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dockerfile looks good, however I think a slightly different approach with the makefile would be better. Let me know what you think.
40be868
to
8564ffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long on this. Feel free to ping me in the future if I take more than a week to reply to a PR.
Anyway, one small change requested but everything else looks OK. In the future I think there's stuff we can do to perhaps minimize some duplication but I'd rather get this in now and deal with that later.
Signed-off-by: Anoop C S <anoopcs@samba.org>
Signed-off-by: Anoop C S <anoopcs@samba.org>
4c3f7e9
to
e495aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a bunch!
Fixes #45