hack: Update controller-gen to v0.14.0 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
force-pushed
the
update-controller-gen
branch
from
8c398eb
to
cb151c6
Compare
synarete
reviewed
Apr 22, 2024
Golang v1.22 doesn't work well[1] with any controller-gen < v0.14.0. Updating controller-gen mandates removal of trivialVersions boolean marker previously used for legacy v1beta1 CRDs[2]. [1] kubernetes-sigs/controller-tools#888 (comment) [2] https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.7.0 Signed-off-by: Anoop C S <anoopcs@samba.org>
Go versions 1.16 and earlier used a different syntax for build constraints, with a "// +build" prefix. We have moved further and at this point it doesn't make sense to keep the old format in source files with current active Go versions. Signed-off-by: Anoop C S <anoopcs@samba.org>
anoopcs9
force-pushed
the
update-controller-gen
branch
from
a0c6c71
to
efb775e
Compare
|
Let me know if anything more is required here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang v1.22 doesn't work well with any controller-gen < v0.14.0. Updating controller-gen mandates removal of trivialVersions boolean marker previously used for legacy v1beta1 CRDs.
fixes #335