Update string.go (#496)

* Update string.go more reasonable * test
samber · Jul 17, 2024 · 1ca9c7b · 1ca9c7b
1 parent f6f43fb
commit 1ca9c7b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/string.go b/string.go
@@ -58,7 +58,7 @@ func Substring[T ~string](str T, offset int, length uint) T {
 		}
 	}
 
-	if offset > size {
+	if offset >= size {
 		return Empty[T]()
 	}
 

diff --git a/string_test.go b/string_test.go
@@ -76,6 +76,7 @@ func TestSubstring(t *testing.T) {
 	str12 := Substring("hello", -4, math.MaxUint)
 	str13 := Substring("🏠🐶🐱", 0, 2)
 	str14 := Substring("你好，世界", 0, 3)
+	str15 := Substring("hello", 5, 1)
 
 	is.Equal("", str1)
 	is.Equal("", str2)
@@ -91,6 +92,7 @@ func TestSubstring(t *testing.T) {
 	is.Equal("ello", str12)
 	is.Equal("🏠🐶", str13)
 	is.Equal("你好，", str14)
+	is.Equal("", str15)
 }
 
 func TestRuneLength(t *testing.T) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,7 +58,7 @@ func Substring[T ~string](str T, offset int, length uint) T { @@
     		}
     	}
-    	if offset > size {
+    	if offset >= size {
     		return Empty[T]()
     	}
@@ Expand Down @@