fix: utf8 input Substring
#288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.28% // Head: 99.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
==========================================
- Coverage 99.28% 99.28% -0.01%
==========================================
Files 15 15
Lines 1971 1958 -13
==========================================
- Hits 1957 1944 -13
Misses 13 13
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/ping |
1 similar comment
|
/ping |
samber
added a commit
that referenced
this pull request
Mar 20, 2023
|
Fixed in #327. I added tests for the helper. Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #286
potential breaking change, because previously
lo.Substringdidn't handle utf8 input correctly.ChunkStringworks becausefor i := string(...)behave likefor i := []rune(string(...)), but we didn't convert~stringto[]runeinSubstring,string(...)[start:end]doesn't handle utf8.