-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: preallocate in Assign #484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samber
approved these changes
Jun 30, 2024
github-actions bot
referenced
this pull request
in kairos-io/provider-kairos
Jul 13, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://github.com/samber/lo) | `v1.44.0` -> `v1.45.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.44.0/v1.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.44.0/v1.45.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.45.0`](https://github.com/samber/lo/releases/tag/v1.45.0) [Compare Source](https://github.com/samber/lo/compare/v1.44.0...v1.45.0) #### What's Changed - perf: preallocate in Assign by [@​pmalek](https://github.com/pmalek) in [https://github.com/samber/lo/pull/484](https://github.com/samber/lo/pull/484) - feat: adding EarliestBy and LatestBy functions by [@​timych](https://github.com/timych) in [https://github.com/samber/lo/pull/489](https://github.com/samber/lo/pull/489) #### New Contributors - [@​pmalek](https://github.com/pmalek) made their first contribution in [https://github.com/samber/lo/pull/484](https://github.com/samber/lo/pull/484) - [@​timych](https://github.com/timych) made their first contribution in [https://github.com/samber/lo/pull/489](https://github.com/samber/lo/pull/489) **Full Changelog**: samber/lo@v1.44.0...v1.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jul 17, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://github.com/samber/lo) | `v1.44.0` -> `v1.46.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fsamber%2flo/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fsamber%2flo/v1.44.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fsamber%2flo/v1.44.0/v1.46.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.46.0`](https://github.com/samber/lo/releases/tag/v1.46.0) [Compare Source](https://github.com/samber/lo/compare/v1.45.0...v1.46.0) #### What's Changed - fix: chunk memory leak, bug fix by [@​mihir20](https://github.com/mihir20) in [https://github.com/samber/lo/pull/491](https://github.com/samber/lo/pull/491) - feat: add WaitForWithContext by [@​ccoVeille](https://github.com/ccoVeille) in [https://github.com/samber/lo/pull/480](https://github.com/samber/lo/pull/480) - add ForEachCondition implement by [@​Sianao](https://github.com/Sianao) in [https://github.com/samber/lo/pull/485](https://github.com/samber/lo/pull/485) #### New Contributors - [@​mihir20](https://github.com/mihir20) made their first contribution in [https://github.com/samber/lo/pull/491](https://github.com/samber/lo/pull/491) - [@​ccoVeille](https://github.com/ccoVeille) made their first contribution in [https://github.com/samber/lo/pull/480](https://github.com/samber/lo/pull/480) - [@​Sianao](https://github.com/Sianao) made their first contribution in [https://github.com/samber/lo/pull/485](https://github.com/samber/lo/pull/485) **Full Changelog**: samber/lo@v1.45.0...v1.46.0 ### [`v1.45.0`](https://github.com/samber/lo/releases/tag/v1.45.0) [Compare Source](https://github.com/samber/lo/compare/v1.44.0...v1.45.0) #### What's Changed - perf: preallocate in Assign by [@​pmalek](https://github.com/pmalek) in [https://github.com/samber/lo/pull/484](https://github.com/samber/lo/pull/484) - feat: adding EarliestBy and LatestBy functions by [@​timych](https://github.com/timych) in [https://github.com/samber/lo/pull/489](https://github.com/samber/lo/pull/489) #### New Contributors - [@​pmalek](https://github.com/pmalek) made their first contribution in [https://github.com/samber/lo/pull/484](https://github.com/samber/lo/pull/484) - [@​timych](https://github.com/timych) made their first contribution in [https://github.com/samber/lo/pull/489](https://github.com/samber/lo/pull/489) **Full Changelog**: samber/lo@v1.44.0...v1.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heuristically preallocate in
Assign
.Assumption is that
Assign
is typically called with maps with different keys. For this invocations the benefit is the greatest.Worst case scenario is when all the keys in all the merged maps are the same. The allocations for those calls are unnecessary but the execution time is roughly the same.
The preallocation factor can be decreased to e.g. half the count of all the entries in all the provided maps to try to cover both mentioned scenarios.