Add Fine, Fine{1->6} #495
Add Fine, Fine{1->6} #495
Conversation
yuweiweiouo
force-pushed
the
master
branch
4 times, most recently
from
fe91b7f
to
4053043
Compare
| @@ -113,6 +113,76 @@ func Must6[T1, T2, T3, T4, T5, T6 any](val1 T1, val2 T2, val3 T3, val4 T4, val5 | |||
| return val1, val2, val3, val4, val5, val6 | |||
| } | |||
|
|
|||
| // just assume fine if err is nil or true. | |||
| func fine(err any) bool { | |||
There was a problem hiding this comment.
I won't use err as a variable name here, as the type is unknown.
I would update the signature of all Just* methods
But it's the way must was written, so …
There was a problem hiding this comment.
This is a reasonable suggestion, maybe I can adjust must along with it.
There was a problem hiding this comment.
How do you feel about changing err to failure?
There was a problem hiding this comment.
Naming is a pain.
@samber is better than I am 😬😂
There was a problem hiding this comment.
I have a good friend named ChatGPT. Perfect for brainstorming.
|
Hi @yuweiweiouo and thanks for your first contribution. About the naming, At first, I thought that "Just" was referring to the reactive programming helper that creates a stream of N elements. Can you suggest other names?
|
Thanks for your review. I really like short and strong names like |
|
Hi @samber |
Summary
This PR introduces a new helper function named
Finealong withFine1toFine6. These functions are designed to safely retrieve values while ignoring errors, ensuring that in the case of an error, empty values are returned instead of triggering a panic.Motivation
In many scenarios, developers may only be interested in retrieving a value and are willing to ignore potential errors without risking a panic. The existing
Musthelper function, while useful, panics when an error is encountered, which might not always be desirable. TheFinehelper and its variants (Fine1toFine6) provide a safer alternative by returning empty values in case of an error.Unlike
Must, which can handle zero return values,Finefocuses solely on the values returned by a function. Therefore, there is noFine0variant, as it would be redundant.