FanoutHandler: prevent mulitple wrapping with errors.Join
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `Handle`, invoke `errors.Join` just once so errors are not wrapped multiple times. See: [golang/go#60209](golang/go#60209)
|
obviously! |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 11 11
Lines 283 286 +3
=====================================
- Misses 283 286 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
renovate bot
added a commit
to jippi/dottie
that referenced
this pull request
Aug 25, 2024
….mod (#86) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/slog-multi](https://github.com/samber/slog-multi) | `v1.2.0` -> `v1.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/slog-multi (github.com/samber/slog-multi)</summary> ### [`v1.2.1`](https://github.com/samber/slog-multi/releases/tag/v1.2.1) [Compare Source](https://github.com/samber/slog-multi/compare/v1.2.0...v1.2.1) #### What's Changed - FanoutHandler: prevent mulitple wrapping with `errors.Join` by [@​ItalyPaleAle](https://github.com/ItalyPaleAle) in [samber/slog-multi#10 #### New Contributors - [@​ItalyPaleAle](https://github.com/ItalyPaleAle) made their first contribution in [samber/slog-multi#10 **Full Changelog**: samber/slog-multi@v1.2.0...v1.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */1 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Handle, invokeerrors.Joinjust once so errors are not wrapped multiple times.See: golang/go#60209