Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportProgrammer.IOptions for multiple transformers case. #1336

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

samchon
Copy link
Owner

@samchon samchon commented Oct 21, 2024

When @nestia/core calls AssertProgrammer like functions, the transformed code occurs duplicated importment statement error. To solve this problem, I've decided to add ImportTransformer.IOptions.internalPrefix to avoid such situation.

For reference, the typia's transformer will assign the typia_transform_ prefix to there, and @nestia/core will do nestia_core_transform_.

When `@nestia/core` calls `AssertProgrammer` like functions, the transformed code occurs duplicated importment statement error. To solve this problem, I've decided to add `ImportTransformer.IOptions.internalPrefix` to avoid such situation.

For reference, the `typia`'s transformer will assign the `typia_transform_` prefix to there, and `@nestia/core` will do `nestia_core_transform_`.
@samchon samchon added the enhancement New feature or request label Oct 21, 2024
@samchon samchon self-assigned this Oct 21, 2024
Copy link

pkg-pr-new bot commented Oct 21, 2024

Open in Stackblitz

npm i https://pkg.pr.new/typia@1336

commit: 3611a72

Copy link
Owner Author

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

@samchon samchon merged commit 8fc9539 into v7.0 Oct 21, 2024
11 checks passed
@samchon samchon deleted the feat/import branch October 21, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant