Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app to customJS object (global app is deprecated) #66

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

ebullient
Copy link
Contributor

Add the plugin app reference to window.customJS, as the global app reference has been deprecated.

@saml-dev
Copy link
Owner

Will the access to this.app be similarly deprecated down the road? I'm wondering if this is just delaying the inevitable (which is fine too lol)

main.ts Outdated Show resolved Hide resolved
@ebullient
Copy link
Contributor Author

Will the access to this.app be similarly deprecated down the road? I'm wondering if this is just delaying the inevitable (which is fine too lol)

I don't think so. The App is passed to the plugin as part of the API for setting up plugins (there are a lot of reasons we have to have it).

Fixed, rebased, repushed

@saml-dev saml-dev merged commit 944d502 into saml-dev:master Oct 7, 2023
@saml-dev
Copy link
Owner

saml-dev commented Oct 7, 2023

Thanks! Will cut a release with this later today.

@saml-dev
Copy link
Owner

saml-dev commented Oct 8, 2023

Released in 1.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants