Implement factory method for new instance creation in CustomJS #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new factory method to the CustomJS evalFile function, allowing the creation of new instances of dynamically imported classes. This change enables users to instantiate new objects as needed, instead of relying solely on a single, shared instance. The method `createClassNameInstance` has been added to the `window.customJS` object, which returns a new instance of the specified class each time it is called.
|
Good idea, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #77 - Enhance instance creation flexibility in CustomJS
This pull request addresses the issue raised in #77, where the CustomJS plugin was limited to creating and providing only a singleton instance of each class. The proposed change allows for greater flexibility by enabling the creation of new instances on demand.
Changes made:
window.customJS.createClassNameInstance, to allow users to create new instances as needed.With this update, users can continue to access the singleton instance for shared state scenarios or opt to create separate instances for isolated state management. This enhancement maintains backward compatibility while providing additional functionality.
Please review the changes and let me know if there are any concerns or additional modifications needed.