Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier: install prettier and eslint #80

Merged
merged 5 commits into from
Jan 6, 2024

Conversation

julesvirallinen
Copy link
Contributor

@julesvirallinen julesvirallinen commented Jan 3, 2024

commits readable in order

  • adds prettier as near as possible to current styling
    • two spaces, semicolons etc.
  • adds eslint with a few recommended rules
    • and e.g. function spacing for legibility
  • kills any's and a couple other type funks

(also bumps node to 18, if we're not ready for that, then eslint needs debumping)
(PS i'd very strongly recommend committing package.lock as is standard, removes a lot of friction when working with node)

If we get this in I can add commit hook to lint / github action check / whatever.

@saml-dev
Copy link
Owner

saml-dev commented Jan 6, 2024

sounds great, thanks. feel free to add whatever package-lock.json you have on your next PR, I live on the wild side and fresh npm install when I cut a release 😅

@saml-dev saml-dev merged commit 6881879 into saml-dev:master Jan 6, 2024
@julesvirallinen
Copy link
Contributor Author

wild! let's lock in the node version and package-lock, should save a lot of trouble in the future :D stuff like this can cause major pain when stuff needs to be upgraded and people have different envs :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants